Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Headers.getAll() #8284

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Remove Headers.getAll() #8284

merged 1 commit into from
Aug 25, 2021

Conversation

ddbeck
Copy link
Contributor

@ddbeck ddbeck commented Aug 25, 2021

Headers.getAll() has been removed from browsers for over two years. Consequently, it's being removed from BCD. This PR:

  • Redirects getAll() to get() (which, in contemporary browsers, does the same thing)
  • Removes all the mentions of getAll that I could find 👋

@ddbeck ddbeck requested review from a team as code owners August 25, 2021 11:35
@ddbeck ddbeck requested review from Rumyra and removed request for a team August 25, 2021 11:35
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers
on GitHub
Flaw count: 17

  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/MozVoicemail
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/MozVoicemailEvent
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/MozVoicemailStatus
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/Navigator/mozVoicemail
    • and 12 more flaws omitted

URL: /en-US/docs/Web/API/Headers
Title: Headers
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Headers/forEach does not exist
  • bad_bcd_links:
    • no explanation!

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Headers
Title: Headers
on GitHub


URL: /en-US/docs/Web/API/Headers/get
Title: Headers.get()
on GitHub

No external URLs

@teoli2003
Copy link
Contributor

Thanks, Daniel! 👏

@teoli2003 teoli2003 merged commit 3137e13 into mdn:main Aug 25, 2021
@ddbeck ddbeck deleted the remove-headers-getall branch August 25, 2021 11:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants