Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete minimize() as it's XUL-only #9175

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Delete minimize() as it's XUL-only #9175

merged 1 commit into from
Sep 23, 2021

Conversation

talha-ah
Copy link
Contributor

Issue number that this PR fixes (if any). For example: 'Fixes #987654321'
No Issue found

What was wrong/why is this fix needed? (quick summary only)
windows.minimize() is apparently XUL-only, which means this is proprietary Firefox functions, which we should not document here.

Anything else that could help us review it
Another PR for this same issue: #9147

@talha-ah talha-ah requested review from a team as code owners September 22, 2021 19:23
@talha-ah talha-ah requested review from Rumyra and removed request for a team September 22, 2021 19:23
@wbamberg wbamberg mentioned this pull request Sep 23, 2021
Merged
@wbamberg
Copy link
Collaborator

Thanks @talha-ah ! Since @teoli2003 commented on #9147 I asked for his opinion on deleting this page and the links.

@teoli2003 teoli2003 merged commit c888129 into mdn:main Sep 23, 2021
@teoli2003 teoli2003 mentioned this pull request Sep 23, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talha-ah @wbamberg @teoli2003