Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PublicKeyCredential[Creation/Request]Options dicts #9714

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Drop PublicKeyCredential[Creation/Request]Options dicts #9714

merged 2 commits into from
Oct 13, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the PublicKeyCredentialCreationOptions and PublicKeyCredentialRequestOptions dictionaries from MDN web docs to follow along with their removal in BCD, see mdn/browser-compat-data#12771.

@queengooborg queengooborg requested review from a team as code owners October 10, 2021 13:01
@queengooborg queengooborg requested review from sideshowbarker and removed request for a team October 10, 2021 13:01
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 10, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/API/CredentialsContainer/create
Title: CredentialsContainer.create()
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/CredentialCreationOptions does not exist
    • /en-US/docs/Web/API/PasswordCredentialData does not exist
    • /en-US/docs/Web/API/CredentialData does not exist
    • /en-US/docs/Web/API/FederatedCredentialInit does not exist
    • /en-US/docs/Web/API/CredentialData does not exist

URL: /en-US/docs/Web/API/CredentialsContainer/get
Title: CredentialsContainer.get()
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/CredentialRequestOptions does not exist

External URLs

URL: /en-US/docs/Web/API/CredentialsContainer/create
Title: CredentialsContainer.create()
on GitHub


URL: /en-US/docs/Web/API/CredentialsContainer/get
Title: CredentialsContainer.get()
on GitHub

(this comment was updated 2021-10-10 13:08:10.583333)

@sideshowbarker sideshowbarker changed the title Remove PublicKeyCredential[Creation/Request]Options dicts from MDN Drop PublicKeyCredential[Creation/Request]Options dicts Oct 13, 2021
@sideshowbarker sideshowbarker merged commit 9eb7270 into mdn:main Oct 13, 2021
@queengooborg queengooborg deleted the PublicKeyCredentialOptions branch October 13, 2021 07:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants