Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RTCTrackEventInit dictionary from MDN #9772

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Remove RTCTrackEventInit dictionary from MDN #9772

merged 1 commit into from
Oct 29, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the documentation for the RTCTrackEventInit dictionary and folds it into the RTCTrackEvent() constructor. Correlates with its removal in BCD, see mdn/browser-compat-data#12831.

@queengooborg queengooborg requested review from a team as code owners October 13, 2021 17:13
@queengooborg queengooborg requested review from teoli2003 and jpmedley and removed request for a team October 13, 2021 17:13
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 13, 2021
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/RTCTrackEvent/RTCTrackEvent
Title: RTCTrackEvent()
on GitHub

No new external URLs

wbamberg
wbamberg approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @queengooborg !

@wbamberg wbamberg merged commit 189d721 into mdn:main Oct 29, 2021
@queengooborg queengooborg deleted the RTCTrackEventInit branch October 29, 2021 02:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003 teoli2003 is a code owner automatically assigned from mdn/yari-content-mdn

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @wbamberg