Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MediaKeySystemConfiguration dictionary from MDN #9786

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Remove MediaKeySystemConfiguration dictionary from MDN #9786

merged 2 commits into from
Oct 15, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the documentation for the MediaKeySystemConfiguration dictionary. Correlates with its removal in BCD, see mdn/browser-compat-data#12840.

@queengooborg queengooborg requested a review from a team October 14, 2021 00:03
@queengooborg queengooborg requested review from a team as code owners October 14, 2021 00:03
@queengooborg queengooborg requested review from schalkneethling, teoli2003 and jpmedley and removed request for a team October 14, 2021 00:03
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 14, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2021

Preview URLs

Flaws

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Navigator/requestMediaKeySystemAccess
Title: Navigator.requestMediaKeySystemAccess()
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/MediaKeySystemConfiguration redirects to /en-US/docs/Web/API/MediaKeySystemAccess/getConfiguration

External URLs

URL: /en-US/docs/Web/API/Encrypted_Media_Extensions_API
Title: Encrypted Media Extensions API
on GitHub


URL: /en-US/docs/Web/API/Navigator/requestMediaKeySystemAccess
Title: Navigator.requestMediaKeySystemAccess()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MediaKeySystemAccess
Title: MediaKeySystemAccess
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MediaKeySystemAccess/getConfiguration
Title: MediaKeySystemAccess.getConfiguration()
on GitHub

No new external URLs

(this comment was updated 2021-10-15 16:11:34.974667)

- : A non-empty {{jsxref('Array')}} of {{domxref('MediaKeySystemConfiguration')}}
objects. The first element with a satisfiable configuration will be used.
- : A non-empty {{jsxref('Array')}} of objects conforming to the object returned by
{{domxref("MediaKeySystemAccess.getConfiguration")}}. The first element with a satisfiable configuration will be used.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be indented to line up under the ":", or the <dl> isn't rendered properly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or I guess it could just be one line?

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a broken <dl> here, otherwise I think this makes sense :)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @queengooborg !

@wbamberg wbamberg merged commit e04c030 into mdn:main Oct 15, 2021
@queengooborg queengooborg deleted the MediaKeySystemConfiguration branch October 15, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants