Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double backticks in forbidden_header_name guide #9953

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

lionralfs
Copy link
Contributor

Summary

The forbidden header name page has an issue in the 2nd paragraph with double backticks. Sec- is rendered as `Sec-`.

Motivation

Make it look clean (?), and uniform with the way it's displayed in the following paragraph.

Supporting details

It looks like #9630 introduced this, which apparently converted HTML files to markdown, but it seems that the issue existed before as: `<code>Sec-</code>`. I couldn't find when this was actually introduced.

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@lionralfs lionralfs requested a review from a team as a code owner October 20, 2021 12:54
@lionralfs lionralfs requested review from ddbeck and removed request for a team October 20, 2021 12:54
@github-actions github-actions bot added the Content:Glossary Glossary entries label Oct 20, 2021
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Glossary/Forbidden_header_name
Title: Forbidden header name
on GitHub

No new external URLs

Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you, @lionralfs. 🎉

@ddbeck ddbeck merged commit 8c846c6 into mdn:main Oct 20, 2021
@lionralfs lionralfs deleted the patch-1 branch October 20, 2021 13:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:Glossary Glossary entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants