renaming :matches to :is #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
reviewed
Nov 15, 2018
css/selectors.json
Outdated
| ":matches": { | ||
| "syntax": ":matches( <selector># )", | ||
| ":is": { | ||
| "syntax": ":is( <selector># )", |
There was a problem hiding this comment.
Can you also please change <selector># to <complex-selector># to minimise breakage of #287 (which should’ve been meged before this)
There was a problem hiding this comment.
Sure; updated.
ExE-Boss
reviewed
Nov 15, 2018
css/selectors.json
Outdated
| ":matches": { | ||
| "syntax": ":matches( <selector># )", | ||
| ":is": { | ||
| "syntax": ":is( <complex-selector># )", | ||
| "groups": [ | ||
| "Pseudo-classes", | ||
| "Selectors" | ||
| ], | ||
| "status": "standard", |
There was a problem hiding this comment.
Also, this is probably experimental now.
There was a problem hiding this comment.
Ack, forgot about that, thanks! I did set it as experimental in BCD.
ExE-Boss
reviewed
Nov 15, 2018
css/selectors.json
Outdated
|
Ah, so that's the official syntax that represents a complex selector list, so we don't need to write "one or more complex selectors". Works for me. Updated. |
|
To minimise merge conflicts, #287 should probably be merged first. |
ExE-Boss
approved these changes
Nov 28, 2018
|
Done and merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per w3c/csswg-drafts#3258