Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Selectors: add "Grouping Selectors" #393

Merged
merged 3 commits into from
Oct 16, 2019
Merged

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Oct 12, 2019

@chrisdavidmills
Copy link
Contributor

The Travis run failed because you are trying to use a group type that doesn't exist. I'd suggest just using Basic Selectors instead of Grouping Selectors, as it is a pretty basic type.

Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css/selectors.json Outdated Show resolved Hide resolved
css/selectors.json Outdated Show resolved Hide resolved
@chrisdavidmills
Copy link
Contributor

Ah, thanks for sorting that out @ExE-Boss . You are right that we should use Selector list.

@ramiy to add new group type, you add it to the group list at

https://github.com/mdn/data/blob/e82e4caa73d88b0edcb52ae579c75e479c320997/css/definitions.json

@chrisdavidmills chrisdavidmills merged commit 99a0ffc into mdn:master Oct 16, 2019
@chrisdavidmills
Copy link
Contributor

OK, let's try that out for size. Thanks @ramiy !

@ramiy ramiy deleted the patch-1 branch October 16, 2019 19:27
@ExE-Boss
Copy link
Contributor

Next, we’ll need to update KumaScript’s CSSRef macro to account for the new sidebar group, like I did for combinators in mdn/kumascript#942.

@ExE-Boss
Copy link
Contributor

A new version of mdn‑data has to be published before this will show up on MDN (because of mdn/kumascript#1126)

@ramiy
Copy link
Contributor Author

ramiy commented Oct 19, 2019

The last version released over 3 months ago... It's time to release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants