Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CSS data for Scroll-driven animations spec #669

Merged
merged 13 commits into from
Jun 20, 2023

Conversation

chrisdavidmills
Copy link
Contributor

Description

The Scroll-driven animations spec is being more or less supported in its entirety in Chromium 115. This PR adds CSS data for the new properties, functions, and other syntax defined in this spec, plus some related syntax from the CSS Animations Level 2.

See my research document for more details as to what has been added.

Motivation

Additional details

Related issues and pull requests

@bramus
Copy link

bramus commented Jun 14, 2023

Note that scroll-timeline-attachment and view-timeline-attachment are no longer part of the spec and got replaced by timeline-scope. This was a very late change to the spec, explaining why it wasn’t caught.

@bramus
Copy link

bramus commented Jun 14, 2023

Also, scroll-timeline-name and view-timeline-name require <dashed-ident>s instead of <custom-ident>s to avoid name clashes with standard CSS keywords.

@chrisdavidmills
Copy link
Contributor Author

Thanks for the heads-up @bramus. I have made changes as required.

@bsmth bsmth self-requested a review June 19, 2023 12:16
@bramus
Copy link

bramus commented Jun 19, 2023

Awesome, thanks!

l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
css/syntaxes.json Outdated Show resolved Hide resolved
css/syntaxes.json Outdated Show resolved Hide resolved
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving a +1 with some open comments. I presume the missing MDN pages are incoming in a separate PR.

Thanks @chrisdavidmills 👍🏻

chrisdavidmills and others added 4 commits June 19, 2023 20:04
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
…mills/data into scroll-driven-animations-data
@bsmth bsmth merged commit fba5d21 into mdn:main Jun 20, 2023
@chrisdavidmills chrisdavidmills deleted the scroll-driven-animations-data branch June 20, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants