-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Enable ESLint and Prettier for all files #2288
Conversation
4613798
to
3e0b7fa
Compare
92bf959
to
c0690be
Compare
c0690be
to
9e316f6
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
9e316f6
to
2500738
Compare
I can see few problems with this commit:
Except for that I can see clear benefits of this PR. Most of the examples would look better with those changes applied. |
This pull request has merge conflicts that must be resolved before it can be merged. |
2500738
to
bc7e374
Compare
Hey @nschonni, thoughts on the comments here #2288 (comment) |
This pull request has merge conflicts that must be resolved before it can be merged. |
bc7e374
to
e522933
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
Hey @nschonni and @NiedziolkaMichal, First, thank you for the work you have done here, Nick. There were a couple of items brought up by Michal here #2288 (comment) Please review them when you have a moment. Also, there are a couple of conflicts at the moment, mainly in |
e522933
to
5425351
Compare
The config does have overrides for particular files interactive-examples/.eslintrc Line 71 in 2315bc6
If you've got suggestions for those, then I can add them, but I didn't see anything actionable for me from the comments above |
This pull request has merge conflicts that must be resolved before it can be merged. |
5425351
to
7bbf13f
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
Hey @nschonni and @NiedziolkaMichal, We had a chat about this one. The work here is great and something we want but, the following topic raised by Michal is a blocker at the moment.
We have brought this to the attention of engineering and will follow up on this in the new year. We are also discussing whether this can be something the community can assist with if we have low-bandwidth internally. We hope this makes sense and is acceptable to you all. Thanks again for the work done. |
7bbf13f
to
a8bf427
Compare
f28909c
to
f4c6ea6
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
f4c6ea6
to
8649536
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
- Remove ESLint rules that overlap with Prettier/EditorConfig - Remove Prettier rules overlapping with EditorConfig - Replace Prettier-eslint with plugin/config versions - Set Environment to ES2022 and remove globals that are not required - Remove babel parser, since covered by ES2022 - Ignore WASM folders because of top level awaits - Rename script commands to match mdn/content
8649536
to
75f055e
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
@NiedziolkaMichal, @bsmth, anyone opposed to us landing this one? |
I think the changes are good, but it might be best if these two PRs land first so we don't introduce display issues: |
I have assigned reviewers for these pull requests. |
This is a little big, so I can try and break it down a bit, if the end result is desired: