Simplify function signature

Just use a boolean, keep things simple
mdn · Feb 27, 2021 · de8b101 · de8b101
1 parent 4c7c440
commit de8b101
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/client/src/document/ingredients/browser-compatibility-table/feature-row.tsx b/client/src/document/ingredients/browser-compatibility-table/feature-row.tsx
@@ -103,15 +103,15 @@ function NonBreakingSpace() {
 
 function labelFromString(
   version: string | boolean | null | undefined,
-  action: string
+  removed?: boolean
 ) {
   if (typeof version !== "string") {
     return <>{"?"}</>;
   }
   if (!version.startsWith("≤")) {
     return <>{version}</>;
   }
-  const actionDescription = action === "removed" ? "ended" : "started";
+  const actionDescription = removed ? "ended" : "started";
   const versionDescription = `version ${version.slice(1)} or earlier`;
   const title = `Support ${actionDescription} in ${versionDescription} (specific version unknown)`;
   return (
@@ -144,7 +144,7 @@ const CellText = React.memo(
         status = { isSupported: "no" };
         break;
       default:
-        status = { isSupported: "yes", label: labelFromString(added, "added") };
+        status = { isSupported: "yes", label: labelFromString(added) };
         break;
     }
 
@@ -153,18 +153,15 @@ const CellText = React.memo(
         isSupported: "no",
         label: (
           <>
-            {labelFromString(added, "added")}
-            <NonBreakingSpace />— {labelFromString(removed, "removed")}
+            {labelFromString(added)}
+            <NonBreakingSpace />— {labelFromString(removed, true)}
           </>
         ),
       };
     } else if (currentSupport && currentSupport.partial_implementation) {
       status = {
         isSupported: "partial",
-        label:
-          typeof added === "string"
-            ? labelFromString(added, "added")
-            : "Partial",
+        label: typeof added === "string" ? labelFromString(added) : "Partial",
       };
     }