-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS tools are broken by the redesign #5392
Comments
That is definitely on the roadmap. I am going to look into this and see if we can at least improve the current situation. Thanks for filing @wbamberg |
Any update on this? |
I looked into the issues:
PS: The tools are located in mdn/css-examples. |
@wbamberg Can you elaborate what you mean by Yari supporting these tools directly? |
I mean that at the moment these are (architecturally and organizationally) part of content: they're implemented using the code sample mechanism and maintained by (technically) writers. But they are not code samples, they are features of a website. So (for example):
They should be treated as purely part of the website, like the homepage or the search page, maintained by engineers within Yari and presented to users as tools, not content pages. Look at how w3schools has a link to a color picker on every page, presented as a separate thing from content pages. And the picker is integrated properly into the site's design, and is responsive on smaller screens. It's so much better than what we have. (I should add that they were IIRC done a long time ago by a GSOC person under @teoli2003 's supervision, and the person did a really great job IMO) |
There is a consensus to keep these around - I believe @schalkneethling suggested the following:
How does that sound? |
I'm not sure I understand this plan. The tools are already in a separate repo (at least, separate from mdn/content) - I moved them into css-examples when we markdownified MDN. When we say "Add to a separate repo where they can be served statically" - served how? As GH pages? But they are already GH pages. Personally, as I said above, I think they should be part of yari, since otherwise it is hard to integrate them into the website design (for example, having good contrasting colours or making it responsive). But if we don't want to do that, I'm not sure how much it matters whether they are in css-examples or some other repo. I'm not sure what "update" covers. Does it mean, fixing the breakage reported in this issue and in mdn/css-examples#157? Does it also mean making them responsive and making the color scheme work with the MDN themes? I suppose the main thing there is to have the resources to do this work. So I suppose there are really three options?
So is the plan (3)? That would be OK. Certainly better than where we are now. |
Yes pretty much @wbamberg - @schalkneethling I believe suggested finding community members who would like to practise their coding to update, whilst that might be the long game, I do like the idea |
The four tools aren't maintained, responsive, or necessary, and some don't work. We shouldn't be hilighting them until they're fixed. see: * https://github.com/mdn/content/issues/21987 (* mdn#5392
I submitted a PR to remove the tools from the sidebar; I don't think we should be promoting the tools until the issues addressed in this PR are addressed. Note: there are some issues in css-examples for the border-image tool |
These pages:
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders/Border-image_generator
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders/Box-shadow_generator
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Colors/Color_picker_tool
...no longer fit in the space allocated to them in the page.
Long term these tools should (IMO) be supported in Yari directly, not hacked in as iframes embedding GitHub pages.
The text was updated successfully, but these errors were encountered: