fix(ai-help): nicer error message #10424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an icon and background for the error generating answer error message.
github-actions
bot
added
plus
caugner
requested changes
Jan 30, 2024
| @@ -6,6 +6,6 @@ export const MESSAGE_SEARCHING = "Searching for MDN content…"; | |||
| export const MESSAGE_SEARCHED = "Consulted MDN content:"; | |||
| export const MESSAGE_ANSWERING = "Generating your answer…"; | |||
| export const MESSAGE_ANSWERED = "Answer:"; | |||
| export const MESSAGE_FAILED = "Error generating your answer!"; | |||
| export const MESSAGE_FAILED = "Error generating your answer! Please try again."; | |||
There was a problem hiding this comment.
For consistency, could we add the "Please try again" in React and make "try again" a button/link that resubmits the question? Like here:
yari/client/src/plus/ai-help/index.tsx
Lines 677 to 680 in 4a663e1
caugner
requested changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add an icon and background for the error generating answer error message.
(MP-678)
Screenshots
Before
After
How did you test this change?
Added
<div className="ai-help-message-progress errored">{MESSAGE_FAILED}</div>inyari/client/src/plus/ai-help/index.tsx
Line 320 in 4a663e1