fix(build/matches): remove unnecessary type imports #10634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation [1], type imports can be registered by using `@types/mdast`. And we have already added this dev-dependency, so remove the import of `mdast-util-directive`. Removed the dependency added in mdn#8133. [1]: https://www.npmjs.com/package/mdast-util-directive#types
github-actions
bot
added
the
dependencies
caugner
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Good catch, LGTM, and verified locally that the callback's node parameter still has its type inferred here:
Line 43 in 9658fca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to the documentation, types can be registered by using
@types/mdast. And we have already added this dev-dependency, so remove the import ofmdast-util-directive.Removed the dependency added in #8133.