fix(article-footer): show red heart emoji in Chrome/Edge #10677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a compatibility issue with the Inter font in Chromium, the red heart emoji was displayed in black.
fiji-flo
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-927)
Problem
The heart emoji in the article footer (when submitting feedback) is shown in black in Chrome/Edge, because there seems to be a compatibility issue affecting the Inter fonts in Chromium.
Solution
Avoid the Inter font for the emoji by wrapping it in a
<span>and using the browser's default font.Screenshots
(Chrome:)
Before
After
How did you test this change?
Ran
yarn dev, then opened http://localhost:3000/en-US/docs/Web#developer_tools_documentation in Chrome 122.