fix(build): prevent adding only-in-en-us css class to external links
#11327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
flaw-system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #11434
Problem
The resolved redirection link may also be an external one. But we haven't check this before assigning the
enUSFallbackURL, which caused theonly-in-en-usCSS class to be added accidentally to the external links.Solution
Check whether the resolved URL is an external one, if so, do not assign the
enUSFallbackURL. Which means, theonly-in-en-usCSS class would not be added.Screenshots
Checkout the git commit sha
f277be087b9484b077fc734e5192d83bc3ee04a1, which is the last commit sha before the fix in translated-content (mdn/translated-content#21711).Check the section
/zh-CN/docs/Mozilla/Add-ons/WebExtensions/Your_first_WebExtension#打包和发布:Before
See: #11434
After
How did you test this change?
Run
yarn dev, and check the rendered page.