fix(sandbox): add allow-forms so <dialog /> element could work properly
#11693
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. Five months ago I met and fixed a similar problem in playground #10788 |
I am not sure if I should update the test code as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11692
Fixes #11460
Problem
<dialog />element doesn't work as expected in example of https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog#html-only_dialog. With chrome console,Blocked form submission to '' because the form's frame is sandboxed and the 'allow-forms' permission is not set.is reported.Solution
I add
allow-formsto the sandbox in embed live example file.Before
After