-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(telemetry): measure BCD table views, link clicks, cell expansions #12030
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
client/src/document/ingredients/browser-compatibility-table/index.tsx
Outdated
Show resolved
Hide resolved
fbf7105
to
8a60430
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great one issue that's needs to be addressed.
client/src/document/ingredients/browser-compatibility-table/index.tsx
Outdated
Show resolved
Hide resolved
client/src/document/ingredients/browser-compatibility-table/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @fiji-flo
client/src/document/ingredients/browser-compatibility-table/utils.ts
Outdated
Show resolved
Hide resolved
client/src/document/ingredients/browser-compatibility-table/feature-row.tsx
Outdated
Show resolved
Hide resolved
client/src/document/ingredients/browser-compatibility-table/feature-row.tsx
Outdated
Show resolved
Hide resolved
f382197
to
f40b76f
Compare
f40b76f
to
2b9c595
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
(MP-1619)
Problem
We don't know how many users use the BCD tables.
Solution
Add measurements for viewing the BCD table, and expanding cells in it.
How did you test this change?
Ran
yarn dev
with these.env
entries: