feat(survey): homepage survey 2024 #12115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
caugner
requested changes
Nov 12, 2024
client/src/document/on-github.tsx
Outdated
| @@ -4,13 +4,13 @@ export function OnGitHubLink({ doc }: { doc: Doc }) { | |||
| return ( | |||
| <div id="on-github" className="on-github"> | |||
| <SourceOnGitHubLink doc={doc}> | |||
| {doc.locale !== "de" | |||
| {doc.locale !== "fr" | |||
There was a problem hiding this comment.
These changes need to be reverted.
There was a problem hiding this comment.
Ah, I was looking at my TS issue there and added it 🙈
| import { survey_duration, survey_rates } from "../../../env"; | ||
|
|
||
| export interface Survey { | ||
| key: SurveyKey; | ||
| bucket: SurveyBucket; | ||
| show: (doc: Doc) => boolean; | ||
| show: (doc: { mdn_url: string }) => boolean; |
There was a problem hiding this comment.
Semantically better:
Suggested change
| show: (doc: { mdn_url: string }) => boolean; | |
| show: (doc: Partial<Doc, "mdn_url">) => boolean; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want user input for our homepage. So we put a survey up.
Screenshots
Before
After
How did you test this change?
Locally and testing