Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macros/SeeCompatTable): update localized links for ja #6858

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

mfuji09
Copy link
Contributor

@mfuji09 mfuji09 commented Aug 11, 2022

Summary

Update localized links in SeeCompatTable.ejs for ja
Related: #3882 (but for ja locale)

Problem

The URL fragments in the macro haven't been localized yet.

Solution

Update the URLs in the macro.
And update URL for "Experimental" (which has been moved).


Screenshots

Before

After


How did you test this change?

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Aug 11, 2022
@fiji-flo
Copy link
Contributor

@mfuji09 I looked at https://developer.mozilla.org/ja/docs/Web/HTTP/Status/425 and the link to the compat table works already, so this PR would break it. Is this an inconsistency between html and markdown pages?

@mfuji09
Copy link
Contributor Author

mfuji09 commented Aug 13, 2022

@fiji-flo
Yes. BCD tables in HTML pages have #browser_compatibility, however markdown pages have localized id, #ブラウザーの互換性. An example of markdown page is: https://developer.mozilla.org/ja/docs/Web/API/Element
From now on, HTML pages will be translated into markdown, so I think macros should be changed.

@caugner
Copy link
Contributor

caugner commented Aug 18, 2022

@mfuji09 Currently, ja still has more index.htmls than index.mds. Have you considered opening a translated-content PR to update all #browser_compatibility links/anchors to #ブラウザーの互換性 in files/ja/**/index.html, to improve the user experience until all files are migrated?

@caugner caugner changed the title Update localized links in SeeCompatTable.ejs for ja fix(macros/SeeCompatTable): update localized links for ja Aug 18, 2022
@mfuji09
Copy link
Contributor Author

mfuji09 commented Aug 18, 2022

@caugner
We (the ja locale team) have started to convert the rest html files to markdown using conversion script. (See mdn/translated-content#7782 )

Therefore, #browser_compatibility anchors will be replaced with localized one, and the current link won't be work soon.

@caugner caugner merged commit 02f5e07 into mdn:main Aug 18, 2022
@mfuji09 mfuji09 deleted the patch-1 branch August 18, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants