fix(macros/htmlattrdef): use inline-block for self-link #7129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise Safari doesn't apply scroll-margin-top.
queengooborg
approved these changes
Oct 28, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6427 by making the self-referencing anchor an inline-block.
Problem
We use a
scroll-margin-topto make sure targeted anchors display below our sticky header, but Safari seems to ignorescroll-margin-topfor inline elements (see here), so the targeted anchor ends up behind the sticky header.Solution
Make the anchor an inline-block via a newly introduced utility class.
Screenshots
Before
After
How did you test this change?
Opened http://localhost:3000/en-US/docs/Web/HTML/Element/button#attr-autocomplete locally in Safari.