chore(advertising): update copies #8562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiji-flo
approved these changes
Apr 3, 2023
Added in 8933d6c.
Which links do you refer to, afaik there was only one link to the "Advertise with us" page:
|
caugner
force-pushed
the
MP-317-update-ad-copies
branch
from
a9a825c
to
8933d6c
Compare
wbamberg
added a commit
to wbamberg/yari
that referenced
this pull request
Apr 4, 2023
* upstream/main: (251 commits) chore(deps-dev): bump typescript from 4.9.5 to 5.0.3 in /client/pwa (mdn#8547) chore(deps-dev): bump typescript from 4.9.5 to 5.0.3 (mdn#8543) chore(deps-dev): bump postcss-preset-env from 8.2.0 to 8.3.0 (mdn#8561) chore(deps-dev): bump @types/react from 18.0.31 to 18.0.32 (mdn#8560) chore(advertising): update copies (mdn#8562) fix(client): place hash before headings (mdn#8532) chore(deps-dev): bump ts-jest from 29.0.5 to 29.1.0 (mdn#8559) chore(deps-dev): bump black from 23.1.0 to 23.3.0 in /deployer (mdn#8555) chore(deps-dev): bump webpack-dev-server from 4.13.1 to 4.13.2 (mdn#8558) chore(deps-dev): bump swr from 2.1.1 to 2.1.2 (mdn#8556) chore(deps): bump boto3 from 1.26.99 to 1.26.104 in /deployer (mdn#8557) chore(deps-dev): bump black in /testing/integration (mdn#8554) ci(stage-build): rsync with -j html,json,txt (mdn#8549) ci(stage-build): rsync with -c (mdn#8548) chore(deps-dev): bump react-router and react-router-dom from 6.9.0 to 6.10.0 (mdn#8534) chore(deps-dev): bump @babel/preset-env from 7.20.2 to 7.21.4 (mdn#8544) chore(deps-dev): bump tailwindcss from 3.3.0 to 3.3.1 (mdn#8546) chore(deps): bump @mdn/browser-compat-data from 5.2.46 to 5.2.47 (mdn#8545) chore(deps-dev): bump @babel/core from 7.21.3 to 7.21.4 (mdn#8542) fix(docs): make icons in good/bad examples float (mdn#8531) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the copy texts of the advertising pages now that the experiment has been finished.
Changes
/advertising./advertising/with_usto/advertising.Screenshots
/advertising/advertising/with_usHow did you test this change?
Ran
yarn devlocally and visited both http://localhost:3000/advertising and http://localhost:3000/advertising/with_us.