feat(build): collect errors + warnings with @sentry/node #8571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
caugner
changed the title
caugner
force-pushed
the
add-build-sentry
branch
from
218cb10
to
506d4b4
Compare
This was referenced Apr 5, 2023
github-actions
bot
added
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
1 similar comment
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
LeoMcA
approved these changes
May 11, 2023
Note: This will only capture build errors.
FWIW @LeoMcA Your manual stage-build yesterday took 26m 57s, and now mine took 26m 53s on this branch. Sentry just adds an error handler or a log middleware, so it only incurs runtime cost when errors actually occur. PS: Interestingly, the scheduled runs seem to be slightly faster, around 25m 10s (last night, Tuesday, Monday). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We emit a lot of warnings and errors during our yari builds, but we don't actively track them.
Solution
Adds and configures Sentry Node to track
console.warn/error/assert()calls during our builds.Note: This does not enable Sentry for the website.
How did you test this change?
Set
SENTRY_DSN_BUILDin my.envfile and ranyarn build:prepare && yarn build --locale en-us --nohtml web/html, verifying that some warnings and errors appear in our (internal) Sentry project.