Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More updates to shape derivative reference values #248

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Dec 2, 2022

Purpose

This is a PR similar to #232. I updated some of the shape derivative reference values for the adjoint test because the changes to the point projection in mdolab/pyspline#51 changed some the geometric derivatives by slightly more than the tolerance.

Expected time until merged

The tests will fail without the pySpline changes, so this PR should be merged at the same time as mdolab/pyspline#51.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Please check that the tests pass locally with the changes from mdolab/pyspline#51.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner December 2, 2022 20:31
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #248 (d6906eb) into main (cf1b4b8) will decrease coverage by 12.45%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #248       +/-   ##
===========================================
- Coverage   41.30%   28.84%   -12.46%     
===========================================
  Files          13       13               
  Lines        3806     3806               
===========================================
- Hits         1572     1098      -474     
- Misses       2234     2708      +474     
Impacted Files Coverage Δ
adflow/pyADflow.py 47.09% <0.00%> (-21.34%) ⬇️
adflow/MExt.py 78.94% <0.00%> (-18.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@anilyil anilyil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I tested locally and they all pass now. I will merge both this and the pyspline PR tomorrow. I did not want to interrupt the current buildbot process.

I realized the tests pass on ARM with -O0. It took a long time but verified the tests before and after this PR. I am testing other optimization levels to see when the tests break on ARM, but this PR is fine as is.

@anilyil anilyil merged commit 069ab31 into main Dec 5, 2022
@anilyil anilyil deleted the embed-ref-2 branch December 5, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants