Removing MPError class in favor of baseclasses Error. #12
Conversation
…cumentation also.
setup.py
Outdated
| @@ -24,6 +24,6 @@ | |||
| packages=[ | |||
| "multipoint", | |||
| ], | |||
| install_requires=["numpy>=1.16", "mpi4py>=3.0"], | |||
| install_requires=["numpy>=1.16", "mpi4py>=3.0", "mdolab-baseclasses>=1.3"], | |||
There was a problem hiding this comment.
Is the plan to release v1.3 today?
There was a problem hiding this comment.
I was contemplating that since we have several new features and functions there. Perhaps we want to wait a bit more for a few other changes to settle in and then bump the minor release. I will change this to v1.2.4 since this is the first version that has the Error class. Should be there now.
| @@ -4,6 +4,7 @@ | |||
| import copy | |||
| from mpi4py import MPI | |||
| import numpy as np | |||
| from baseclasses.utils import Error | |||
There was a problem hiding this comment.
Why do we need this additional import here?
There was a problem hiding this comment.
The createGroups function in there uses it.
There was a problem hiding this comment.
I see, I got confused by the single commit
| @@ -22,4 +22,5 @@ For stability we recommend cloning or checking out a tagged release. | |||
| :maxdepth: 2 | |||
|
|
|||
| tutorial | |||
| examples | |||
There was a problem hiding this comment.
I believe you are missing the examples.rst file that calls the ex1.py script via literalinclude. The examples are not showing up in the docs.
There was a problem hiding this comment.
Forgot to commit that one. Should be there now.
Purpose
This PR,
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Checklist
Put an
xin the boxes that apply.flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted