Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python syntax + flake8/pylint fixes #17

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Update python syntax + flake8/pylint fixes #17

merged 3 commits into from
Aug 10, 2021

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Aug 6, 2021

Purpose

This PR updates python syntax via pyupgrade, and I also made some pylint/flake8 fixes.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Existing tests pass.

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner August 6, 2021 15:16
@ewu63 ewu63 requested review from joanibal and marcomangano August 6, 2021 15:16
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #17 (bd370c4) into master (f1726c3) will increase coverage by 0.59%.
The diff coverage is 50.00%.

❗ Current head bd370c4 differs from pull request most recent head 22e224c. Consider uploading reports for the commit 22e224c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   72.84%   73.44%   +0.59%     
==========================================
  Files           3        3              
  Lines         372      369       -3     
==========================================
  Hits          271      271              
+ Misses        101       98       -3     
Impacted Files Coverage Δ
multipoint/multiPointSparse.py 77.81% <45.00%> (ø)
multipoint/utils.py 45.28% <66.66%> (+2.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1726c3...22e224c. Read the comment docs.

@joanibal joanibal merged commit e7a2500 into master Aug 10, 2021
@ewu63 ewu63 deleted the pyupgrade branch August 18, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants