Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 updates #2

Merged
merged 4 commits into from
Apr 7, 2020
Merged

Python 3 updates #2

merged 4 commits into from
Apr 7, 2020

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Apr 7, 2020

No description provided.

@ewu63 ewu63 requested a review from a team as a code owner April 7, 2020 19:59
@ghost ghost requested review from joanibal and marcomangano April 7, 2020 19:59
marcomangano
marcomangano approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is online testing available already? I don't see any check, I am mostly concerned about other incoming PRs

@ewu63
Copy link
Collaborator Author

ewu63 commented Apr 7, 2020

We have not been testing this repo. There are tests but they are deprecated, someone will have to revive them and make sure they are good.

@marcomangano marcomangano merged commit d3c2c2c into mdolab:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcomangano marcomangano marcomangano approved these changes

@joanibal joanibal joanibal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewu63 @joanibal @marcomangano