Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fprettify #44

Merged
merged 4 commits into from
Aug 10, 2022
Merged

fprettify #44

merged 4 commits into from
Aug 10, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Aug 9, 2022

Purpose

Formatting the Fortran code with fprettify

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Current test pass

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj
Copy link
Collaborator Author

sseraj commented Aug 9, 2022

Verified that the fprettify check fails without formatting and outputs which files need to be formatted

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #44 (93c3fd8) into main (85281e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   60.51%   60.51%           
=======================================
  Files           5        5           
  Lines        1616     1616           
=======================================
  Hits          978      978           
  Misses        638      638           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sseraj sseraj marked this pull request as ready for review August 9, 2022 14:12
@sseraj sseraj requested a review from a team as a code owner August 9, 2022 14:12
@sseraj sseraj requested review from akleb and bernardopacini August 9, 2022 14:12
@akleb
Copy link
Contributor

akleb commented Aug 9, 2022

Why not stick with the two space tab?

@sseraj
Copy link
Collaborator Author

sseraj commented Aug 9, 2022

Previously, we had an initial 2 space tab and then 3 space tabs after that. We decided to use a 4 space tab to be consistent with our Python formatting.

@sseraj
Copy link
Collaborator Author

sseraj commented Aug 9, 2022

Verified that a single file failure also fails the job

@akleb akleb merged commit 03a6691 into main Aug 10, 2022
@akleb akleb deleted the fprettify branch August 10, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants