Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change linalg.dsolve.factorized to linalg.factorized #53

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented Nov 22, 2022

Purpose

SciPy has started producing the following deprecation warnings when running pySpline:

DeprecationWarning: Please use `factorized` from the `scipy.sparse.linalg` namespace, the `scipy.sparse.linalg.eigen` namespace is deprecated.

This PR updates where we get the factorized function from to fix this. I checked, and the factorized function is available in the new location in scipy 1.5.4 which is the oldest version we currently we support.

Expected time until merged

1 day

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner November 22, 2022 18:41
@A-CGray A-CGray requested review from joanibal and akleb November 22, 2022 18:41
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #53 (2304674) into main (0c78591) will not change coverage.
The diff coverage is 42.85%.

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   52.53%   52.53%           
=======================================
  Files           5        5           
  Lines        1616     1616           
=======================================
  Hits          849      849           
  Misses        767      767           
Impacted Files Coverage Δ
pyspline/pyVolume.py 40.80% <0.00%> (ø)
pyspline/pySurface.py 63.24% <50.00%> (ø)
pyspline/pyCurve.py 51.87% <66.66%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@A-CGray A-CGray changed the title Change linalg.dsolve.factorized to linalg.factorized` Change linalg.dsolve.factorized to linalg.factorized Nov 28, 2022
@A-CGray A-CGray requested review from bernardopacini and removed request for joanibal November 28, 2022 16:17
@anilyil anilyil self-requested a review December 5, 2022 15:43
@anilyil anilyil merged commit cb3ae33 into main Dec 5, 2022
@anilyil anilyil deleted the scipyFix branch December 5, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants