Deploy to PyPI #27
Deploy to PyPI #27
Conversation
There was a problem hiding this comment.
can you update the version and CHANGELOG?
To update the version, we need to change two files:
mauth-client-python/pyproject.toml
Line 3 in e18bc15
.travis.yml
Outdated
| @@ -36,10 +36,13 @@ jobs: | |||
| before_deploy: | |||
| - poetry config repositories.mdsol https://mdsol.jfrog.io/mdsol/api/pypi/pypi-local | |||
There was a problem hiding this comment.
@jfeltesse-mdsol Do we still need to publish to Artifactory? I think publishing just to PyPI is enough.
There was a problem hiding this comment.
agreed, PyPI is enough.
| @@ -36,10 +36,13 @@ jobs: | |||
| before_deploy: | |||
| - poetry config repositories.mdsol https://mdsol.jfrog.io/mdsol/api/pypi/pypi-local | |||
| - poetry config http-basic.mdsol $ARTIFACTORY_USERNAME $ARTIFACTORY_PASSWORD # Stored as Travis CI Environment Vars | |||
| - poetry config pypi-token.pypi $POETRY_PYPI_TOKEN_PYPI # this may be unnecessary | |||
There was a problem hiding this comment.
looks like there is an issue with Environment variable POETRY_PYPI_TOKEN_<NAME> so I think this is necessary for now.
python-poetry/poetry#2210
.travis.yml
Outdated
| script: | ||
| poetry publish -r mdsol | ||
| poetry publish |
There was a problem hiding this comment.
- is missing:
| script: | |
| poetry publish -r mdsol | |
| poetry publish | |
| script: | |
| - poetry publish -r mdsol | |
| - poetry publish |
but if we don't need to publish to Artifactory, it will be just:
script: poetry publish
There was a problem hiding this comment.
why do we need the script provider to begin with? travis supports PyPI: https://docs.travis-ci.com/user/deployment-v2/providers/pypi/
There was a problem hiding this comment.
because we are using poetry python-poetry/poetry#669
| # needed for Python < 3.8 | ||
| import importlib_metadata | ||
|
|
||
| __version__ = importlib_metadata.version(__name__) |
Added settings for deployment to PyPI (env vars in travis)
Removed PyPy (building cryptography from source requires rust)
Added Python 3.9