Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/car mode update #143

Merged
merged 26 commits into from
Nov 22, 2023
Merged

Feature/car mode update #143

merged 26 commits into from
Nov 22, 2023

Conversation

glow-mdsol
Copy link
Member

  • Update CAR support to add mode param (added in Rave EDC 2022.3.0)
  • Update CAR support to add unicode param (added in Classic Rave 2019.2.0)
  • Dep update

@glow-mdsol
Copy link
Member Author

Need to think about what encoding we do on the result to deal with the unicode param

@@ -3,25 +3,44 @@

http://rws-webhelp.s3.amazonaws.com/WebHelp_ENG/solutions/clinical_data_audits/index.html#odm-adapter

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't go anywhere anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to point to Knowledge Hub (along with the others)

@glow-mdsol glow-mdsol requested review from dferraro-mdsol and removed request for drisack-mdsol November 21, 2023 16:31
@jmann-mdsol jmann-mdsol self-requested a review November 22, 2023 17:46
Copy link

@jmann-mdsol jmann-mdsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glow-mdsol glow-mdsol merged commit cbdf33c into develop Nov 22, 2023
7 checks passed
@glow-mdsol glow-mdsol deleted the feature/car_mode_update branch November 22, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants