-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y improvment (part 1) #552
base: main
Are you sure you want to change the base?
Conversation
Thank you for the PR. The project has prettier configured, but for some reason, your PR uses a different formatting which results in a massive change - this makes it very hard for me to review it; the build won't pass as well. Can you fix the formatting? I don't think that the change you mean to introduce should change 300+lines. |
Yeah, I don't know why it don't apply... I'll fix that and push a new commit |
@petyosi I think we are good now |
The missing imports were so weird... It should have worked at all 🤔 Anyway, it's fixed. I also fixed the spacing but had to make some compromises to have the exact same render : I had to externalize the |
First part of the improvments proposed in #544 :
The only thing I could not do is to translate the new locale entry to all languages