fix: allow comments to contain --

mdx-js · Sep 14, 2021 · 6c2d9dd · 6c2d9dd
1 parent 2a5792f
commit 6c2d9dd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/packages/eslint-mdx/src/regexp.ts b/packages/eslint-mdx/src/regexp.ts
@@ -23,7 +23,7 @@ export const openTag = '<[A-Za-z]*[A-Za-z0-9\\.\\-]*' + attribute + '*\\s*>'
 export const closeTag = '<\\s*\\/[A-Za-z]*[A-Za-z0-9\\.\\-]*\\s*>'
 export const selfClosingTag =
   '<[A-Za-z]*[A-Za-z0-9\\.\\-]*' + attribute + '*\\s*\\/?>'
-export const comment = '<!---->|<!--(?:-?[^>-])(?:-?[^-])*-->'
+export const comment = '<!--(?:[^-]|-(?:[^-]|-+[^->]))*-*-->'
 export const commentOpen = '(<!---*)'
 export const commentClose = '(-*-->)'
 export const commentContent = `${commentOpen}([\\s\\S]*?)${commentClose}`

diff --git a/test/__snapshots__/fixtures.test.ts.snap b/test/__snapshots__/fixtures.test.ts.snap
@@ -169,6 +169,8 @@ Array [
 ]
 `;
 
+exports[`fixtures should match all snapshots: comments.mdx 1`] = `Array []`;
+
 exports[`fixtures should match all snapshots: details.mdx 1`] = `
 Array [
   Object {

diff --git a/test/fixtures/comments.mdx b/test/fixtures/comments.mdx
@@ -0,0 +1 @@
+<!-- eslint-disable-next-line no-console -- Here's a description about why this configuration is necessary. -->
-Original file line number
+Diff line change
@@ Expand Up / @@ -169,6 +169,8 @@ Array [ @@
     ]
     `;
+    exports[`fixtures should match all snapshots: comments.mdx 1`] = `Array []`;
     exports[`fixtures should match all snapshots: details.mdx 1`] = `
     Array [
       Object {
@@ Expand Down @@
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		<!-- eslint-disable-next-line no-console -- Here's a description about why this configuration is necessary. -->