Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] restored loc column is still incorrect when startLine is not 1 #292

Closed
JounQin opened this issue Mar 19, 2021 · 0 comments · Fixed by #293
Closed

[bug] restored loc column is still incorrect when startLine is not 1 #292

JounQin opened this issue Mar 19, 2021 · 0 comments · Fixed by #293
Labels
🏡 area/internal This affects the hidden internals 🧒 semver/minor This is backwards-compatible change 🐛 type/bug This is a problem 🙆 yes/confirmed This is confirmed and ready to be worked on

Comments

@JounQin
Copy link
Member

JounQin commented Mar 19, 2021

https://github.com/mdx-js/eslint-mdx/blob/master/packages/eslint-mdx/src/helpers.ts#L122-L130
@JounQin JounQin added 🐛 type/bug This is a problem 🙉 open/needs-info This needs some more info labels Mar 19, 2021
JounQin added a commit that referenced this issue Mar 19, 2021
@JounQin
fix: add helper getLocFromRange
618e5ec 
close #292
@JounQin JounQin mentioned this issue Mar 19, 2021
Merged
@JounQin JounQin added 🏡 area/internal This affects the hidden internals 🙆 yes/confirmed This is confirmed and ready to be worked on 🧒 semver/minor This is backwards-compatible change and removed 🙉 open/needs-info This needs some more info labels Mar 19, 2021
JounQin added a commit that referenced this issue Mar 20, 2021
@JounQin
fix: add helper getPositionAt to fix incorrect loc (#293)
260a07e 
* fix: add helper getPositionAt

close #292

* refactor: simplify offset which is always start actually

* chore: all settings are optional

* refactor: use a better and cleaner way to hack

* chore: run typecov and improve types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏡 area/internal This affects the hidden internals 🧒 semver/minor This is backwards-compatible change 🐛 type/bug This is a problem 🙆 yes/confirmed This is confirmed and ready to be worked on
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add helper getPositionAt to fix incorrect loc mdx-js/eslint-mdx
1 participant
@JounQin