-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add helper getPositionAt to fix incorrect loc #293
Conversation
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 512 521 +9
Branches 100 100
=========================================
+ Hits 512 521 +9
Continue to review full report at Codecov.
|
@wooorm ready for a patch release! |
@JounQin I can’t release, there’s a typescript error when running
|
Released! |
close #292
The following has been resolved!
I don't know if there is a better and cleaner way without source `code` or `lines`.
OK, I found maybe we have to use this approach because the loc column of start node could be incorrect as described at #279 (comment), while the start offset is always correct.