-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use processor to display remark reports directly #281
Conversation
@wooorm I'm still confused how to set report severity in remark config, or should I add a setting in |
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 21 +2
Lines 448 464 +16
Branches 88 90 +2
=========================================
+ Hits 448 464 +16
Continue to review full report at Codecov.
|
Severity cannot be configured in a reporter, because it has no clue how serious things are. |
|
What did you see? |
https://github.com/remarkjs/remark-lint/issues?q=+severity |
🤷♂️ These are issues that include the word severity. They do not show what you mean... |
@wooorm Check remarkjs/remark-lint#65 (comment) instead. It seems not all rules support this option. |
That’s my comment. From 5 years ago. The issue is closed because severities were added back then. 5 years ago...
Please back this up. What are you running into? What is the problem? |
To clarify: all remark lint rules allow this. But unified !== remark-lint. ESLint is only a linter. unified is 500 projects. Some of them don’t support configuring severities. |
Sorry, my problem seems related to remarkjs/remark-lint#98 So |
@wooorm Then this PR is ready to review and merge now! |
@mdx-js/releasers @wooorm Please help to release a minor version. |
done |
This will make the report much more familiar with original
remark-lint
plugins.