Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use processor to display remark reports directly #281

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Mar 11, 2021

This will make the report much more familiar with original remark-lint plugins.

image

@JounQin JounQin added the 🦋 type/enhancement This is great to have label Mar 11, 2021
@JounQin JounQin self-assigned this Mar 11, 2021
@JounQin
Copy link
Member Author

JounQin commented Mar 11, 2021

@wooorm I'm still confused how to set report severity in remark config, or should I add a setting in eslint-plugin-mdx instead.

@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #281 (7a513a2) into master (171488e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #281   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        21    +2     
  Lines          448       464   +16     
  Branches        88        90    +2     
=========================================
+ Hits           448       464   +16     
Impacted Files Coverage Δ
.eslintrc.js 100.00% <100.00%> (ø)
packages/eslint-plugin-mdx/src/configs/base.ts 100.00% <100.00%> (ø)
...ackages/eslint-plugin-mdx/src/configs/overrides.ts 100.00% <100.00%> (ø)
...kages/eslint-plugin-mdx/src/configs/recommended.ts 100.00% <100.00%> (ø)
packages/eslint-plugin-mdx/src/index.ts 100.00% <100.00%> (ø)
packages/eslint-plugin-mdx/src/processors/index.ts 100.00% <100.00%> (ø)
...ackages/eslint-plugin-mdx/src/processors/remark.ts 100.00% <100.00%> (ø)
packages/eslint-plugin-mdx/src/rules/remark.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171488e...7a513a2. Read the comment docs.

@wooorm
Copy link
Member

wooorm commented Mar 11, 2021

I'm still confused how to set report severity in remark config, or should I add a setting in eslint-plugin-mdx instead.

Severity cannot be configured in a reporter, because it has no clue how serious things are.
Plugins default to warning. They can sometimes be configured.

@JounQin
Copy link
Member Author

JounQin commented Mar 11, 2021

They can sometimes be configured.

sometimes seems bad, is there any plan to improve it like eslint? I saw may requests about it.

@wooorm
Copy link
Member

wooorm commented Mar 11, 2021

is there any plan to improve it like eslint? I saw may requests about it.

What did you see?
How could it be improved?

@JounQin
Copy link
Member Author

JounQin commented Mar 11, 2021

What did you see?
How could it be improved?

https://github.com/remarkjs/remark-lint/issues?q=+severity

@wooorm
Copy link
Member

wooorm commented Mar 11, 2021

🤷‍♂️

These are issues that include the word severity. They do not show what you mean...

@JounQin
Copy link
Member Author

JounQin commented Mar 11, 2021

🤷‍♂️

These are issues that include the word severity. They do not show what you mean...

@wooorm Check remarkjs/remark-lint#65 (comment) instead.

It seems not all rules support this option.

@wooorm
Copy link
Member

wooorm commented Mar 11, 2021

That’s my comment. From 5 years ago. The issue is closed because severities were added back then. 5 years ago...

It seems not all rules support this option.

Please back this up. What are you running into? What is the problem?

@wooorm
Copy link
Member

wooorm commented Mar 11, 2021

To clarify: all remark lint rules allow this.

But unified !== remark-lint.

ESLint is only a linter. unified is 500 projects. Some of them don’t support configuring severities.

@JounQin
Copy link
Member Author

JounQin commented Mar 11, 2021

Sorry, my problem seems related to remarkjs/remark-lint#98

So ["lint-no-duplicate-headings",[2]] is working actually.🤣

@JounQin
Copy link
Member Author

JounQin commented Mar 11, 2021

@wooorm Then this PR is ready to review and merge now!

@JounQin JounQin merged commit 5052eb8 into master Mar 12, 2021
@JounQin JounQin deleted the feat/processor branch March 12, 2021 02:54
@JounQin
Copy link
Member Author

JounQin commented Mar 12, 2021

@mdx-js/releasers @wooorm Please help to release a minor version.

@wooorm
Copy link
Member

wooorm commented Mar 16, 2021

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

3 participants