Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: migrate to GitHub Actions instead #322

Merged
merged 2 commits into from
Jul 10, 2021
Merged

ci: migrate to GitHub Actions instead #322

merged 2 commits into from
Jul 10, 2021

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jul 10, 2021

@wooorm Here we go.

@JounQin JounQin added 🏡 area/internal This affects the hidden internals 🕸️ area/tests This affects tests labels Jul 10, 2021
@JounQin JounQin requested a review from wooorm July 10, 2021 08:18
@JounQin JounQin self-assigned this Jul 10, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 10, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2021 •
edited
Loading

Codecov Report

Merging #322 (b5594a9) into master (0041bdd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #322    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           16        21     +5     
  Lines          314       507   +193     
  Branches        58       106    +48     
==========================================
+ Hits           314       507   +193
Impacted Files Coverage Δ
.eslintrc.js 100.00% <ø> (ø)
test/helpers.ts 100.00% <ø> (ø)
packages/eslint-mdx/src/helpers.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/index.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/parser.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/regexp.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/traverse.ts 100.00% <100.00%> (ø)
packages/eslint-plugin-mdx/src/configs/base.ts 100.00% <100.00%> (ø)
...kages/eslint-plugin-mdx/src/configs/code-blocks.ts 100.00% <100.00%> (ø)
...ackages/eslint-plugin-mdx/src/configs/overrides.ts 100.00% <100.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea49cac...b5594a9. Read the comment docs.

JounQin
JounQin commented Jul 10, 2021
View reviewed changes
README.md
@@ -10,8 +10,7 @@
</a>
</p>

[![Travis](https://img.shields.io/travis/com/mdx-js/eslint-mdx.svg)](https://travis-ci.com/mdx-js/eslint-mdx)
[![Codacy Grade](https://img.shields.io/codacy/grade/4ea8225261c04837995a858676caae4b)](https://www.codacy.com/app/JounQin/eslint-mdx)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wooorm Can you help to enable https://app.codacy.com/manual/mdx-js/eslint-mdx for this repo only? I think codacy is a good service to display the project code grade.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really prefer to keep such tools to a minimum.
Each new service provides a new vector to be hacked.
Recently codecov had an incident: https://about.codecov.io/security-update/.
The less services you use, the more secure things are.

Can you do without it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, not a required one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wooorm Good to approve then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good otherwise!!

@JounQin JounQin mentioned this pull request Jul 10, 2021
Merged
@JounQin JounQin merged commit b31723d into master Jul 10, 2021
@JounQin JounQin deleted the ci branch July 10, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees

@JounQin JounQin

Labels
🏡 area/internal This affects the hidden internals 🕸️ area/tests This affects tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JounQin @codecov-commenter @wooorm