Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error with correct loc #382

Merged
merged 1 commit into from
Apr 18, 2022
Merged

fix: throw error with correct loc #382

merged 1 commit into from
Apr 18, 2022

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Apr 7, 2022

No description provided.

@JounQin JounQin added the 🐛 type/bug This is a problem label Apr 7, 2022
@JounQin JounQin self-assigned this Apr 7, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #382 (ae9d3c6) into master (68d41a1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head ae9d3c6 differs from pull request most recent head 4231a8e. Consider uploading reports for the commit 4231a8e to get more accurate results

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   99.04%   99.06%   +0.01%     
==========================================
  Files          18       18              
  Lines         210      214       +4     
  Branches       38       40       +2     
==========================================
+ Hits          208      212       +4     
  Misses          1        1              
  Partials        1        1              
Impacted Files Coverage Δ
packages/eslint-mdx/src/parser.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d41a1...4231a8e. Read the comment docs.

Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, right?

@JounQin JounQin merged commit c497839 into master Apr 18, 2022
@JounQin JounQin deleted the fix/error_loc branch April 18, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

3 participants