-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade micromark-util-events-to-acorn #383
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 18 18
Lines 214 214
Branches 40 42 +2
=======================================
Hits 212 212
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
@wooorm Any time to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Is that all that’s needed to update to MDX 2? 🤔
There is another known issue for now. |
@wooorm That issue doesn't block this PR, I think it's ready for a new |
sure! |
P.S. can you update deps (at least gajus/eslint-plugin-jsdoc#880 (comment)) so everything builds on Node.js 18? |
Released 2.0.0-next.2! |
related micromark/micromark-extension-mdx-expression#4
close #380