-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add publish workflow for releasing on CI automatically #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other stuff looks 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t see anything weird, but I have no real experience with publishing to vscode.
I have completely forgotten how to get those tokens. Any ideas? Must I add them before this can be merged?
Right. For vsce, it should be added at |
And also, I'd like to enable https://github.com/changesets/changesets for auto releasing with better CHANGELOG, just sent an installation request, can you help to accept? |
It seems you've claimed already for And the next questions are:
|
I approved the two applications you requested on the two repos you maintain here
I added you as a contributor on open-vcx. Which permissions do you mean?
You already are a contributor in that organization. What else do you need.
As discussed before, I don’t think that it's safe for all members to access all information in the unified organizations that has many different contributors. We already have a releasers team in the MDX organization that has access to that, and we have the core team that has access to that. I think we should have a small number of people that have access to vulnerable information. There is already a |
I believe that all the docs on vscode extensions are out of date. These URLs and guides don’t work for me. |
@wooorm Great to know! Then the last thing left should be |
I have no permission to add secret. The token will be expired in one year, that's a question. |
https://dev.azure.com/{account}/_usersSettings/tokens This link is not outdated and works to me, maybe you have a different username for Microsoft account? |
remarkjs/vscode-remark#40 (comment) Previous context that may help. @wooorm cc @asbjornu Do you have a latest |
🦋 Changeset detectedLatest commit: 338c662 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I indeed have different accounts. None of those accounts can access that page.
If I added it a year ago, I don’t think so. I am guessing it will work. |
OK then, let's merge and give it a try! |
https://github.com/mdx-js/vscode-mdx/runs/7279615594?check_suite_focus=true#step:6:20 @wooorm Please help to see, maybe a new token is required for a new extension. |
It's already available at https://open-vsx.org/extension/unifiedjs/vscode-mdx, but not https://marketplace.visualstudio.com/items?itemName=unifiedjs.vscode-mdx |
microsoft/vsmarketplace#354 (comment). Ideas:
|
I hope we can do that also, but found no solution yet. |
What's the current status here and how may I be of assistance? :) |
We want to transfer my extension to Or is that possible to contact MS service? (I'm not a native English speaker, if you could such help, that would be great!) |
run: yarn --frozen-lockfile | ||
|
||
- name: ovsx publish | ||
uses: HaaLeo/publish-vscode-extension@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any benefits to use this action instead of the official vsce
CLI?
Also: nice that this extension is also published to the Open VSX registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It keeps usage consistency between vsce and open-vsx, I supposed?
@JounQin, have a look at the discussion in remarkjs/vscode-remark#28. I don't remember exactly how we did it, but I think by reading the comments you should figure out what we did to move |
@asbjornu Back then we used the same “top-level” identifier: |
Ok, then I have no idea, sorry. 🤷🏼 |
Perhaps we can try uploading the extension to the VSCode markerplace manually. Maybe some special setup is needed for the initial upload. Alternatively we could rename the extension from |
I’m quite liking releasing it as |
https://marketplace.visualstudio.com/items?itemName=unifiedjs.vscode-mdx v1.0.1 is finally been released! Thanks, @madhurivadaligithub, for help at microsoft/vsmarketplace#440 For question: Is that possible to transfer an extension to another publisher org? The answer is YES! |
close #177
close #188
@asbjornu Can you please help to review the publishing workflow?
@wooorm An
OPEN_VSX_TOKEN
and aVSCE_TOKEN
secrets are required.