Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Push diagnostics from server #347

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix: Push diagnostics from server #347

merged 2 commits into from
Oct 31, 2023

Conversation

johnsoncodehk
Copy link
Contributor

As an example, volarjs/starter enables client pull diagnostics by default, which causes vscode to send a diagnostic request to the server when the current file changes, which is invalid for project-aware diagnostics. Specifically, vscode does not re-request .mdx diagnostics when a .ts file is changed that affects the .mdx type.

Remove diagnosticModel: DiagnosticModel.Pull to solve the problem, since the default behavior is server push instead of client pull.

@johnsoncodehk
fix: Push diagnostics from server
366475f 
Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f94d58b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Oct 30, 2023
@github-actions

This comment has been minimized.

Sign in to view
@remcohaszing
Remove unused import
f94d58b 
Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 🗄 area/interface This affects the public interface 🧒 semver/minor This is backwards-compatible change 👍 phase/yes Post is accepted and can be worked on labels Oct 31, 2023
@github-actions github-actions bot removed the 👋 phase/new Post is being triaged automatically label Oct 31, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
remcohaszing
remcohaszing approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@remcohaszing remcohaszing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@remcohaszing remcohaszing merged commit 160a201 into mdx-js:main Oct 31, 2023
8 checks passed
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@remcohaszing remcohaszing added the 💪 phase/solved Post is done label Oct 31, 2023
@github-actions github-actions bot removed the 👍 phase/yes Post is accepted and can be worked on label Oct 31, 2023
@johnsoncodehk johnsoncodehk deleted the patch-1 branch November 1, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcohaszing remcohaszing remcohaszing approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsoncodehk @remcohaszing