-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ability to opt out of MDXProvider components #1175
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mdx/mdx/juf9wwyx7 |
dafd031
to
6c4ff30
Compare
I believe this change will require a change to types for |
6c4ff30
to
86f664a
Compare
86f664a
to
a8120d1
Compare
a8120d1
to
081da76
Compare
081da76
to
f36f3df
Compare
/cc @ChristianMurphy as this is about types too |
This is the type for the MDXProvider mdx/packages/react/types/index.d.ts Lines 19 to 27 in f59b174
the update would look like /**
* Prop type that includes a component dictionary
*/
interface ComponentsProp {
/**
* Mapping of names for JSX components to React components
*/
components: ComponentDictionary
+ /**
+ * description of new property goes here
+ *
+ * @defaultValue true
+ */
+ useParentContext?: boolean
} |
f36f3df
to
d66efb0
Compare
d66efb0
to
5f51880
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔️
Thanks @johno! 🙇
Related to #821