Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to recommend rehype-mdx-code-props #2501

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Fix to recommend rehype-mdx-code-props #2501

merged 1 commit into from
Jun 30, 2024

Conversation

karlhorky
Copy link
Contributor

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Recommend rehype-mdx-code-props by @remcohaszing instead of the deprecated remark-mdx-code-meta

Signed-off-by: Karl Horky <karl.horky@gmail.com>
Copy link

vercel bot commented Jun 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 3:27pm

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (908ff45) to head (62a7644).
Report is 26 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2501   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2693      2712   +19     
  Branches         2         2           
=========================================
+ Hits          2693      2712   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wooorm wooorm changed the title Recommend newer rehype-mdx-code-props Fix to recommend rehype-mdx-code-props Jun 30, 2024
@wooorm wooorm merged commit dfdcb50 into mdx-js:main Jun 30, 2024
6 checks passed
@wooorm wooorm added 📚 area/docs This affects documentation 💪 phase/solved Post is done 🕸 area/website This affects the website labels Jun 30, 2024
@wooorm
Copy link
Member

wooorm commented Jun 30, 2024

thanks! :)

@karlhorky
Copy link
Contributor Author

Glad to help :) thanks for the review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 area/docs This affects documentation 🕸 area/website This affects the website 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

5 participants