Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buble jsx only #790

Merged
merged 7 commits into from
Sep 23, 2019
Merged

Buble jsx only #790

merged 7 commits into from
Sep 23, 2019

Conversation

millette
Copy link
Contributor

@millette millette commented Sep 20, 2019

Replaces buble with buble-jsx-only in runtime for a smaller bundle.

Reference: bublejs/buble#213 (comment)

@vercel
Copy link

vercel bot commented Sep 20, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://mdx-git-fork-millette-buble-jsx-only.mdx.now.sh

@vercel vercel bot temporarily deployed to staging September 20, 2019 19:22 Inactive
@millette
Copy link
Contributor Author

millette commented Sep 20, 2019

I might have messed up some git merges on my end... Basically the only change should be 4c7c034 in packages/runtime/ only.

Tests pass but I've only figured out how to use runtime today, so no garantees.

@vercel vercel bot temporarily deployed to staging September 20, 2019 19:42 Inactive
@millette
Copy link
Contributor Author

It works well with my mini mdx-runtime/nextjs demo and with the terminal (ink) example.

@johno
Copy link
Member

johno commented Sep 23, 2019

Thanks!

@johno johno merged commit 2a78c99 into mdx-js:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants