Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for export * statements in remark-mdx #911

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

zephraph
Copy link
Contributor

@zephraph zephraph commented Jan 13, 2020

Scope

Adds the ability to use an export * statement inside an mdx file.

Context

While working hashicorp/next-mdx-enhanced#37 I kept getting these remark eat errors.

Incorrectly eaten value: please report this warning on https://git.io/vg5Ft

Thanks to the playground I traced it down to the export statement I added to the above PR:

export * from 'blah'

Check out the above PR link for details about why I was trying to add this.

@vercel
Copy link

vercel bot commented Jan 13, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/mdx/mdx/8mksfu2vp
✅ Preview: https://mdx-git-fork-zephraph-support-export-all.mdx.now.sh

@vercel vercel bot temporarily deployed to Preview January 13, 2020 05:08 Inactive
@zephraph zephraph requested a review from johno January 15, 2020 00:58
@johno
Copy link
Member

johno commented Jan 15, 2020

Awesome, thanks!

@johno johno merged commit da7b2cd into mdx-js:master Jan 15, 2020
@zephraph zephraph deleted the support-export-all branch January 16, 2020 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants