Ensure compiling hast doesn't fail if path contains export #912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, so this one threw me for a hell of a loop.
I was writing a test for another plugin that wraps mdx loader and it kept inexplicably failing. I went as far as copying a passing test from somewhere else and it was still failing.
The error was pretty mysterious too:
Turns out, in
mdx-hast-to-jsx.js
, the calculation ofexportNames
will fail if there is a directory namedexport
in the exported file path. Since my test directory was calledlayouts-exports-ssg
it caused layoutProps to output garbage because the regex had a miss-match.You can check the regex here: https://regexr.com/4sar8