Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

problems on nodejs v4.2.1 LTS. #1015

Closed
ezerw opened this issue Oct 22, 2015 · 8 comments
Closed

problems on nodejs v4.2.1 LTS. #1015

ezerw opened this issue Oct 22, 2015 · 8 comments

Comments

@ezerw
Copy link

ezerw commented Oct 22, 2015

Have problems with karma on npm install with nodejs v4.1.2 :

npm WARN engine karma@0.12.37: wanted: {"node":">=0.8 <=0.12 || >=1 <=2"} (current: {"node":"4.1.2","npm":"2.14.4"})
npm WARN peerDependencies The peer dependency istanbul@0.x.x included from grunt-mocha-istanbul will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
@codydaig
Copy link
Member

We don't fully support Node 4 yet. The master branch has some initial support for Node 4, but we don't fully support it yet. We're waiting on all dependencies to catch up, and for us to be able to test and bring them in.

@ezerw
Copy link
Author

ezerw commented Oct 23, 2015

Ok, Thanks!, would be nice to add to that to the main page. Cheers.

@ilanbiala
Copy link
Member

@ezekkiel those are easy fixes and actually, a PR would be very welcome. 1 PR would be to update our dependency of Karma to the latest. Another PR would be to add Istanbul as a devDependency, which will get rid of those warnings.

@codydaig
Copy link
Member

@ezekkiel If you use the master branch of this repo, it does work on Node 4. I've been using it for several weeks now. There are npm WARN messages, but those are just warnings for when npm v3 is released. a PR is still welcome, but not necessary to get it working on Node 4.

@lirantal lirantal assigned lirantal and codydaig and unassigned lirantal Oct 29, 2015
@lirantal lirantal added this to the 0.4.2 milestone Oct 29, 2015
@lirantal
Copy link
Member

@codydaig so we can close it for now then. If problems arise with Node v4 on the latest master branch then we can re-open.

@ilanbiala ilanbiala reopened this Oct 29, 2015
@ilanbiala ilanbiala modified the milestones: 0.5.0, 0.4.2 Oct 29, 2015
@ilanbiala
Copy link
Member

@lirantal this should actually be fixed before we start using npm 3 because it isn't really about Node 4, so I'm going to leave it open and mark it as 0.5.0 if @ezekkiel doesn't submit a PR by then.

@lirantal
Copy link
Member

Ok

@palpalani
Copy link

There is new package for checking node 4.2 compatibily - https://www.npmjs.com/package/upgrade-ready.
Here is the result for master branch - http://upgrade-ready.nodesource.com/summary/adac5b50-8885-11e5-b0d6-136ad07fd6ea

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants