Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Inconsistent file naming convention for certain files in articles module #1192

Closed
0x24a537r9 opened this issue Feb 7, 2016 · 2 comments
Closed

Comments

@0x24a537r9
Copy link
Contributor

If you look at the filenames for the project, they are for the most part very well organized and consistent. There are, however, a few minor exceptions that should probably be fixed in the articles module. In most cases, files are named like:

edit-user.client.view.html
list-users.client.view.html
view-user.client.view.html
edit-profile.client.controller.js
list-graphs.client.view.html

So the format seems to roughly follow the pattern: [hyphenated subject].[client/server].[type].[optional "tests"].js. But then there's:

list.graphs.client.controller.js
list.graphs.client.controller.tests.js

This may be the only example (swapping a - for a .), but it probably makes sense for someone more knowledgeable about the codebase to do a quick review of the filenames to make sure they're consistent.

Does this really matter that much? Probably not. But it's an easy enough fix to agree upon and implement.

@rhutchison
Copy link
Contributor

I assume you mean list.articles.client.controller.js?

@0x24a537r9
Copy link
Contributor Author

Whoops! Yes, sorry. I was looking at my own fork where I had already renamed the files for my own specific use-case.

There may be other filename inconsistencies the repo, but those were the only ones I saw.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants