Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

angularFileUpload resolving to 1.1.8, when installing bower dependencies #722

Closed
mleanos opened this issue Jul 28, 2015 · 5 comments
Closed
Assignees
Milestone

Comments

@mleanos
Copy link
Member

mleanos commented Jul 28, 2015

I wiped out public/lib, and re-installed the Bower dependencies. angular-file-upload has resolved to 1.1.8; even though bower.json has "angular-file-upload": "~1.1.5"

In angularFileUpload 1.1.8, the asset files have moved from public/lib/angular-file-upload/ to public/lib/angular-file-upload/dist; and there's only a .min.js file. The project assets config is looking for angularFileUpload in the former location. Thus, I'm receiving an injection error.

I'm able to resolve it by changing the assets config of default (& production) to the new location; public/lib/angular-file-upload/dist/angular-file-upload.min.js

Can anyone else confirm this is an issue?

@trainerbill
Copy link
Contributor

@mleanos it should match to version 1.1.8 as there is a ~ in the front with will match any patch version. I think the issue is with angular file uploads semver. They pushed a major/minor release to a patch version....

Answer to your question is that yes I am seeing the same issue and this needs to be fixed. I did a bower update and got 1.1.8 which breaks MEAN. Looks to me like there is a 1.2 release. If we are going to work on anything maybe we should go to that?

https://github.com/nervgh/angular-file-upload/releases

@mleanos
Copy link
Member Author

mleanos commented Jul 28, 2015

@trainerbill Thank you for looking into this.

I'm not sure that we need to decide on which version to go with at this exact moment. As each version after 1.1.6 has the dist folder. So the same fix can be applied.

I'll submit a PR, for the above fixes. Afterward, I'll look into which version might be best, and go through some tests.

@mleanos
Copy link
Member Author

mleanos commented Jul 28, 2015

PR #724 is the accurate fix. Leaving this issue open, for discussion about which version to land on.

@simison
Copy link
Member

simison commented Jul 28, 2015

I'd just bluntly test if the latest 5.x works with mean and upgrade bower.json accordingly.

@mleanos
Copy link
Member Author

mleanos commented Jul 29, 2015

Submitted a new PR for this. #729

ilanbiala added a commit that referenced this issue Jul 29, 2015
Update angular-file-upload to use static dependency
Fixes #722, Fixes #724
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants