This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
remove duplicate angular interceptor. Fixes #1096 #1102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
Thanks! @pgrodrigues please re-base in order to maintain 1 commit and update the commit message to a format according to our guidelines: https://github.com/meanjs/mean/blob/master/CONTRIBUTING.md#commit-message-guidelines |
Remove the interceptor defined in the users module Update the interceptor defined in the core module Update the respective test Fixes #1096
|
I'll close this for now and make a new pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1096 and is a step forward towards fixing the issues related with 401/403 status code responses not being handled properly by the client. Consider reading @mleanos post that summarizes the situation.